Combine socket #34
Closed
Combine socket #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # demo/src/main/java/com/ivanempire/lighthouse/demo/MainActivity.kt # lighthouse/src/commonMain/kotlin/com/ivanempire/lighthouse/core/DiscoveryManager.kt # lighthouse/src/commonMain/kotlin/com/ivanempire/lighthouse/core/RealDiscoveryManager.kt # lighthouse/src/main/java/com/ivanempire/lighthouse/LighthouseClient.kt
sproctor
commented
Jul 9, 2024
| emit(discoveryDatagram) | ||
| } | ||
| } | ||
| .catch { cause -> |
There was a problem hiding this comment.
I should have broken this into multiple commits, sorry.
This is a bit tricky to notify with flows. If the connection gets closed, we should handle it gracefully. Also, it would be nice to notify the user. Perhaps the top level data passed to the user should include a connection state.
| val datagramPacketRequest = searchRequest.toDatagramPacket(multicastGroup) | ||
|
|
||
| repeat(retryCount + 1) { | ||
| if (!multicastSocket.isClosed) { |
There was a problem hiding this comment.
This is to fix a crash I experienced. Not sure why the socket wasn't open, but there are apparently times when it's not.
There was a problem hiding this comment.
I am guessing you've seen this on desktop? Or did you observe this on Android?
|
Closing for now since we're both async on this work - feel free to reopen :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.